Open Rewrite Cleanups

Development
1

I was experimenting with running the Open Rewrite recipe “Common static analysis issues” when I added Open Rewrite in the root POM (Issue#220) and to address cleanups (Issue#88).

Running this would change ~2500 files. Often adding/removing whitespace before brackets/braces or adding braces around single-line statements.

If this would be fine, I would activate one cleanup recipe after the other, if they make sense for us. Eventually having cleaner code all over.

Before I would run this again and propose such a huge PR I would like to have your opinion about that. WDYT?

2

Just my personal opinion here :blush:: Every time we do these refactorings, it becomes a bit trickier for me to backport the c7 changes. I feel that instead of focusing on whitespace changes, it might be more beneficial to tackle the bigger tasks like completing the JUnit5 migration or removing outdated JavaEE support completly. Ensuring that the tests run smoothly in IntelliJ would be incredibly valuable.

Whitespace changes, on the other hand, mainly affect metrics without adding substantial value. Perhaps we could save the major refactorings for a few months down the line when the c7 repo is no longer expected to have further updates.

1 Like
3

You are right here. We can perform that later. Of course backporting and keeping that effort low is way more important.

2 Likes