Pull Request Template

May I attract your intention to

I have created a draft for a pull request template. My intention is provide a short guideline to craft good pull requests. One important aspect here is that it should be assured that licenses are respected. This is a IMO low barrier to an important topic, which I see also on other projects. It might become necessary to have later other means (e.g. signing CLA, signing commits), but it is important to keep the barrier to contribute as low as possible.

But there is more in this template, maybe also too much. Please help me by your feedback to get the template soon in place. The template can of course later be improved, but at this time we simply do not anything and we should change that.

Thank you!

1 Like

Thanks for working on this @kthoms. I think it’s great to ask for consent in the PR because this is the lowest barrier possible.

“- Documentation has been updated (if applicable)” this is a bit tricky because the documentation in another repository. Perhaps we should merge the repos?

perhaps we could also add
" - I understand and agree that my contribution including all personal information I submit with it is public and that a record of the contribution is
maintained indefinitely and may be redistributed consistent with
this project."

One last thing would be then what we do with anonymous accounts. There we cannot map the consent given to an actual person.

I can offer to schedule another meeting with our lawyer, concerning the “anonymous commiters”. Requiring the full name might be a dealbreaker for some people. If there was a way to align the legal requirements with anonymous contributions, I would prefer this. If it is not possible, however, we might have no other choice.

1 Like

Would be really cool if we could get input from a lawyer for this.

Yes, I would like to take this chance. How do we find a time? Our Slack channel should be good for this.